[opentelemetry] Split enable_opentelemetry into enable_metrics and enable_tracing#1504
Merged
Merged
Conversation
the-glu
force-pushed
the
split_monitoring_flags
branch
from
992f8ce to
94f0397
Compare
mickmis
approved these changes
Jun 8, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
No backward compatibly added, as the flag is very new, needed manual work to be used and only tracing has been released, who shall only be used for debugging.
If it's been released we should have backward compatibility: even if within our development timeline this is a short window of time, who knows how much time there will be between version upgrades for the users.
Given that only the tracing has been released: just have 'enable_telemetry' be an alias of 'enable_tracing' and add a deprecation notice in the usage of the flag?
Otherwise LGTM
the-glu
force-pushed
the
split_monitoring_flags
branch
2 times, most recently
from
0f8e79a to
2b8cae1
Compare
mickmis
reviewed
Jun 11, 2026
the-glu
force-pushed
the
split_monitoring_flags
branch
from
2b8cae1 to
689f4ce
Compare
Co-authored-by: Mickaël Misbach <mickael.misbach@orbitalize.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow #1503
It split the
enable_opentelemetryflag into two dedicated sub flags.Preparing deployments files to add DSS metrics, it doesn't make sense to enable full tracing just for 'normal' Prometheus metrics, especially as it show warning if partially configured.
No backward compatibly added, as the flag is very new, needed manual work to be used and only tracing has been released, who shall only be used for debugging.